Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR template #1728

Closed
wants to merge 1 commit into from
Closed

Conversation

NotTheDr01ds
Copy link
Contributor

Adds a PR template as recommended in #1722. This probably doesn't save much time, since the user will have already pushed the changes by the time they see this.

I'll look at suppressing the GitHub plugin on the /commands route next.

@fdncred
Copy link
Collaborator

fdncred commented Jan 1, 2025

I'm not sure this is helpful. Seems like it would be more helpful to do at that issue suggests and remove the "Edit this page in Github" if possible. We already have CI that says you can't edit commands help.

@NotTheDr01ds
Copy link
Contributor Author

NotTheDr01ds commented Jan 1, 2025

Well, that issue suggests both courses of action. I did just finished pushing the other half of it, which removes the link.

I agree that I'm not sure it helps all that much for this particular issue, but I don't think it hurts to have a PR template here in general? In the future, we can update it to link to the Style Guide (when updated), for instance.

@fdncred
Copy link
Collaborator

fdncred commented Jan 1, 2025

We can land this, but I personally detest all the <!-- mess on PR templates. It's a hassle on the nushell repo IMO.

@NotTheDr01ds
Copy link
Contributor Author

I'm not tied to it. Let's wait until we have a better use-case.

@NotTheDr01ds
Copy link
Contributor Author

And yes, contributors really should delete the boilerplate before submitting (I do, at least).

@fdncred
Copy link
Collaborator

fdncred commented Jan 1, 2025

i delete the first part of it in the nushell repo, which is why it's a hassle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants