[CS2103T-W08-4] Socius #79
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
============================================
- Coverage 72.15% 68.40% -3.76%
- Complexity 399 886 +487
============================================
Files 70 116 +46
Lines 1232 2877 +1645
Branches 125 438 +313
============================================
+ Hits 889 1968 +1079
- Misses 311 727 +416
- Partials 32 182 +150
Continue to review full report at Codecov.
|
bentanjunrong
pushed a commit
to bentanjunrong/tp
that referenced
this pull request
Oct 13, 2021
Add list commands
Domszy
pushed a commit
to Domszy/tp
that referenced
this pull request
Oct 13, 2021
Update add command user guide description
okyntary
pushed a commit
to okyntary/tp
that referenced
this pull request
Oct 18, 2021
…-date-parsing LGTM
Fix Tag Font Bug
Fix issues from PED
Update Developer Guide
Update User Guide
Fix Phone Number Constraints & Review Remark Prefix Constraints
Add Persons of the Same Name
All commands which involves the parsing of Index will return an Invalid Command Format when a Non-Zero Integer cannot be parsed. According to @xianlinc, the correct error should be 'The person index provided is invalid', no matter how large the input number. [Valid point] I've added a check, such that all string that 1. Contains just numbers AND 2. Not the integer range (i.e between -2 billion to 2 billion) AND 3. Is a positive number (any length), but must not be all 0s... will return Integer.MAX_INT. This assumes that the users will not have 2.147 billion friends in Socius, which should be a reasonable assumption to make (Consider the size of json file and time taken to import!!)
Update DG: Appendix and Misc Part
Update Developer Guide
Update UG screenshots
Add Glossary to UserGuide.md
Update choonyongchan.md
Edits to DG
Remove a few implementations
Fix import export for windows
update link
Fix checking for windows OS
update link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Socius helps fresh international student and enrolled in CS2103T to meet new friends and form project groups.
Socius helps with gathering information about classmates and facilitates students in forming groups with specific candidates.