Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing pointer-cursor for tag-badge in article view #1078

Merged

Conversation

nunocoracao
Copy link
Owner

@nunocoracao nunocoracao commented Dec 1, 2023

Fixes #956

@nunocoracao nunocoracao merged commit 723da1a into dev Dec 1, 2023
3 checks passed
@nunocoracao nunocoracao deleted the 956-missing-pointer-cursor-for-tag-badge-in-article-view branch December 1, 2023 13:16
Copy link

github-actions bot commented Dec 1, 2023

Visit the preview URL for this PR (updated for commit 24cd703):

https://blowfish-21fff--preview-1078-zqwst6vx.web.app

(expires Sun, 31 Dec 2023 13:17:11 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a26980fcadf32d89eb699b2db74c097ea4332e31

@@ -47,7 +47,7 @@
{{ end }}


<div class="flex flex-row flex-wrap items-center">
<div style="cursor: default;" class="flex flex-row flex-wrap items-center">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nunocoracao I think this hides the pointer cursor for article date link. Is that on purpose?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JVimes yes, did you have any use for it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without it, I'd assume the site doesn't link article dates.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @JVimes I am not following the use-case. Can you point me to an example of what worked and doesn't anymore. Maybe we should open a issue for this also.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind, I'm getting my wires crossed with my modifications 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants