Skip to content

Commit

Permalink
Don't remove deps.json runtime infos for Non-SCDMode apps
Browse files Browse the repository at this point in the history
related issues: #48, #50
  • Loading branch information
liesauer committed May 29, 2023
1 parent 56713ae commit 8c0ac96
Show file tree
Hide file tree
Showing 13 changed files with 16 additions and 16 deletions.
2 changes: 1 addition & 1 deletion Common/Common.props
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<PropertyGroup>
<PackageOutputPath>.nupkg</PackageOutputPath>
<Version>2.1.3.4</Version>
<Version>2.1.4.0-beta.1</Version>

<Company>nulastudio</Company>
<Authors>LiesAuer</Authors>
Expand Down
2 changes: 1 addition & 1 deletion NetBeauty/src/main/beauty.go
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ func main() {

usePatch = SCDMode && usePatch

allDeps, _useWPF, _ := manager.FixDeps(deps.deps, deps.main, enableDebug, usePatch, sharedRuntimeMode)
allDeps, _useWPF, _ := manager.FixDeps(deps.deps, deps.main, SCDMode, usePatch, enableDebug, sharedRuntimeMode)

useWPF = _useWPF

Expand Down
4 changes: 2 additions & 2 deletions NetBeauty/src/main/bindata.go

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions NetBeauty/src/manager/manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,7 @@ func FindFXRVersion(deps string) (string, string) {
}

// FixDeps 分析deps.json中的依赖项
func FixDeps(deps string, entry string, enableDebug bool, usePatch bool, sharedRuntimeMode bool) ([]Deps, bool, bool) {
func FixDeps(deps string, entry string, SCDMode bool, usePatch bool, enableDebug bool, sharedRuntimeMode bool) ([]Deps, bool, bool) {
var isAspNetCore = false
var useWPF = false
var verifyWpfDllSet = false
Expand Down Expand Up @@ -608,7 +608,7 @@ func FixDeps(deps string, entry string, enableDebug bool, usePatch bool, sharedR
}

// nbloader dependencies
if !usePatch {
if SCDMode && !usePatch {
if fileName == "System.Collections.dll" ||
fileName == "System.Memory.dll" ||
fileName == "System.Private.CoreLib.dll" ||
Expand Down Expand Up @@ -832,7 +832,7 @@ func FixDeps(deps string, entry string, enableDebug bool, usePatch bool, sharedR
}
}

if !strings.HasPrefix(analyzed.ItemKey, "./") {
if SCDMode && !strings.HasPrefix(analyzed.ItemKey, "./") {
delete(analyzed.Category, analyzed.ItemKey)
}
}
Expand Down
Binary file modified NetBeauty/src/nbloader/nbloader.dll
Binary file not shown.
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="nulastudio.NetBeauty" Version="2.1.3.4" />
<PackageReference Include="nulastudio.NetBeauty" Version="2.1.4.0-beta.1" />
</ItemGroup>

</Project>
2 changes: 1 addition & 1 deletion NetBeautyTest/ChromelyTest/ChromelyTest.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="nulastudio.NetBeauty" Version="2.1.3.4" />
<PackageReference Include="nulastudio.NetBeauty" Version="2.1.4.0-beta.1" />
</ItemGroup>

</Project>
2 changes: 1 addition & 1 deletion NetBeautyTest/NetFxTest/NetFxTest.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@
</ItemGroup>
<Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
<ItemGroup>
<PackageReference Include="nulastudio.NetBeauty" Version="2.1.3.4" />
<PackageReference Include="nulastudio.NetBeauty" Version="2.1.4.0-beta.1" />
<PackageReference Include="SixLabors.ImageSharp">
<Version>2.1.3</Version>
</PackageReference>
Expand Down
2 changes: 1 addition & 1 deletion NetBeautyTest/SharedRuntimeTest/WsClient/WsClient.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@

<ItemGroup>
<PackageReference Include="WatsonWebsocket" Version="2.3.2.5" />
<PackageReference Include="nulastudio.NetBeauty" Version="2.1.3.4" />
<PackageReference Include="nulastudio.NetBeauty" Version="2.1.4.0-beta.1" />
</ItemGroup>

</Project>
2 changes: 1 addition & 1 deletion NetBeautyTest/SharedRuntimeTest/WsServer/WsServer.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@

<ItemGroup>
<PackageReference Include="WatsonWebsocket" Version="2.3.2.5" />
<PackageReference Include="nulastudio.NetBeauty" Version="2.1.3.4" />
<PackageReference Include="nulastudio.NetBeauty" Version="2.1.4.0-beta.1" />
</ItemGroup>

</Project>
4 changes: 2 additions & 2 deletions NetBeautyTest/WPFTest/WPFTest.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
<!-- set to True if you want to disable -->
<DisableBeauty>False</DisableBeauty>
<!-- set to False if you want to beauty on build -->
<BeautyOnPublishOnly>True</BeautyOnPublishOnly>
<BeautyOnPublishOnly>False</BeautyOnPublishOnly>
<!-- set to True if you want to allow 3rd debuggers(like dnSpy) debugs the app -->
<BeautyEnableDebugging>False</BeautyEnableDebugging>
<!-- the patch can reduce the file count -->
Expand All @@ -89,7 +89,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="nulastudio.NetBeauty" Version="2.1.3.4" />
<PackageReference Include="nulastudio.NetBeauty" Version="2.1.4.0-beta.1" />
<PackageReference Include="System.Configuration.ConfigurationManager" Version="7.0.0" />
</ItemGroup>

Expand Down
2 changes: 1 addition & 1 deletion NetBeautyTest/WebAppTest/WebAppTest.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="nulastudio.NetBeauty" Version="2.1.3.4" />
<PackageReference Include="nulastudio.NetBeauty" Version="2.1.4.0-beta.1" />
</ItemGroup>

</Project>
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ Your `*.csproj` should be like:
</PropertyGroup>

<ItemGroup>
<PackageReference Include="nulastudio.NetBeauty" Version="2.1.3.4" />
<PackageReference Include="nulastudio.NetBeauty" Version="2.1.4.0-beta.1" />
</ItemGroup>

</Project>
Expand Down

0 comments on commit 8c0ac96

Please sign in to comment.