Small refactor of the code for better structure, error propagation and preperation for extentions #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the way we represent copy of files in the packInstructions struct. Instead of using the instructions struct of docker frontend, use a map of strings, where the key is the source of the file and the value is the destination of the file. Signed-off-by: Charalampos Mainas <[email protected]>
Restructure the code, in order to allow the creation of a package for bunny. Furthermore, it will help to have a better structure of the code and improve the understandinf and readability. However, much more work is required. Signed-off-by: Charalampos Mainas <[email protected]>
When bunny acts as a frontend for buildkit, printing in stdout will cause a fail. Instead, all errors should be reported as a return value of the function we passs as an argument in the grpc client creation. Moreover, this commit improves the error formating, but more work is required. Signed-off-by: Charalampos Mainas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make some necessary change to improve the way bunny show errors and prepare the code to add support for new file formats.