Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#873] Fixed Checkstyle Issues In HIRS_STRUCTS #876

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

ThatSilentCoder
Copy link
Collaborator

@ThatSilentCoder ThatSilentCoder commented Nov 8, 2024

Description

Checkstyle is used for meeting best practices for java code styling. All classes in HIRS_Structs should be updated to pass checkstyle tests being run by gradle.

Test Instructions:

  1. Follow steps 1 - 3 in this previous pull request: https://github.com/nsacyber/HIRS/pull/846to confirm you can save and apply checkstyle recommended styling changes to your code in your favorite IDE.
  2. Run the command below to confirm that all the checkstyle errors for the HIRS_STRUCTS module have been fixed:
    ./gradlew clean HIRS_Structs:check --rerun-tasks
  3. .Run the command below to confirm that there are no issues building or running tests for the entire application:
    ./gradlew clean build --rerun-tasks
  4. If you were able to run all the commands without running into any issues, you have successfully verified that the checkstyles guidelines have been applied to the these HIRS_Structs module successfully.

Issues this PR addresses:

Closes issue #873

@ThatSilentCoder ThatSilentCoder linked an issue Nov 8, 2024 that may be closed by this pull request
@ThatSilentCoder ThatSilentCoder changed the title [#873] Fixed Checkstyle Issues In HIRS_STRUCT [#873] Fixed Checkstyle Issues In HIRS_STRUCTS Nov 13, 2024
@iadgovuser26 iadgovuser26 merged commit 70d1984 into main Nov 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update HIRS_Structs for checkstyle
2 participants