Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add option ciGroupName to allow customizing the name of… #29365

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tinesoft
Copy link
Contributor

Jest atomized taks group on CI

Current Behavior

When using Atomizer on Jest for unit tests (via the "ciTargetName": "test-ci"), the atomized tasks will be grouped under the misleading name "E2E (CI)".

Worst, if Atomizer is enabled for both unit and e2e tests, it will result on E2E atomized tasks being overwritten by the one from unit tests... when run on Nx Cloud.

Expected Behavior

Allow customizing the name of the atomized tasks group. The group name can be derived from the ciTargetName , when not explicitly provided.

Related Issue(s)

Fixes #28066

@tinesoft tinesoft requested review from a team as code owners December 16, 2024 11:38
Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Dec 23, 2024 8:33am

Copy link

nx-cloud bot commented Dec 16, 2024

View your CI Pipeline Execution ↗ for commit 73d9507.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ❌ Failed 32m 26s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 1m 12s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base=c7e27... ✅ Succeeded 23s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 21s View ↗
nx documentation --no-dte ✅ Succeeded 43s View ↗

☁️ Nx Cloud last updated this comment at 2024-12-23 09:05:05 UTC

Copy link

nx-cloud bot commented Dec 17, 2024

Your CI Pipeline Execution ↗ for commit 86384d3 is in progress ⏳

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 37m 41s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 1m 5s View ↗
nx-cloud record -- nx format:check --base=fb403... ✅ Succeeded 21s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded <1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 20s View ↗
nx documentation --no-dte ✅ Succeeded 43s View ↗

☁️ Nx Cloud last updated this comment at 2024-12-18 09:41:59 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Atomized groups have always suffix E2E (CI). This should be toggleable
1 participant