Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): add nx version to nx files archive #28706

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Cammisuli
Copy link
Member

Current Behavior

When running postinstall with Nx, we create a files archive file. When there are multiple versions of nx installed, the post install would run for all versions. This causes issues where one version might overwrite the archive files while another version is writing to the same location.

Expected Behavior

The setupWorkspaceContext is now only ran when we detect that it is the main nx package. This changes the archive file name to use the version of Nx, so its more unquite. And makes creation of the archive file more atomic so that we dont overwrite files while its being written by other processes

Related Issue(s)

Fixes #

Also makes creation of the archive file more atomic so that we dont
overwrite files while its being written by other processes
Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Nov 1, 2024 0:11am

Copy link

nx-cloud bot commented Oct 30, 2024

Copy link

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx [email protected] my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-28706-16b6403
Release details 📑
Published version 0.0.0-pr-28706-16b6403
Triggered by @Cammisuli
Branch feature/nxc-1151-investigate-bus-errors-135
Commit 16b6403
Workflow run 11599484860

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

Copy link

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx [email protected] my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-28706-f21dc7c
Release details 📑
Published version 0.0.0-pr-28706-f21dc7c
Triggered by @Cammisuli
Branch feature/nxc-1151-investigate-bus-errors-135
Commit f21dc7c
Workflow run 11613164968

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

Copy link

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx [email protected] my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-28706-97af084
Release details 📑
Published version 0.0.0-pr-28706-97af084
Triggered by @Cammisuli
Branch feature/nxc-1151-investigate-bus-errors-135
Commit 97af084
Workflow run 11614447201

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant