-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): add nx version to nx files archive #28706
base: master
Are you sure you want to change the base?
Conversation
Also makes creation of the archive file more atomic so that we dont overwrite files while its being written by other processes
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 611fcc7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx [email protected] my-workspace Or just copy this version and use it in your own command: 0.0.0-pr-28706-16b6403
To request a new release for this pull request, mention someone from the Nx team or the |
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx [email protected] my-workspace Or just copy this version and use it in your own command: 0.0.0-pr-28706-f21dc7c
To request a new release for this pull request, mention someone from the Nx team or the |
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx [email protected] my-workspace Or just copy this version and use it in your own command: 0.0.0-pr-28706-97af084
To request a new release for this pull request, mention someone from the Nx team or the |
Current Behavior
When running postinstall with Nx, we create a files archive file. When there are multiple versions of nx installed, the post install would run for all versions. This causes issues where one version might overwrite the archive files while another version is writing to the same location.
Expected Behavior
The
setupWorkspaceContext
is now only ran when we detect that it is the main nx package. This changes the archive file name to use the version of Nx, so its more unquite. And makes creation of the archive file more atomic so that we dont overwrite files while its being written by other processesRelated Issue(s)
Fixes #