-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): ensure require.resolve('nx') resolves correctly #19800
fix(core): ensure require.resolve('nx') resolves correctly #19800
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 83a40a4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
712aae1
to
dce61a1
Compare
dce61a1
to
da94211
Compare
packages/react/src/executors/module-federation-dev-server/module-federation-dev-server.impl.ts
Outdated
Show resolved
Hide resolved
da94211
to
2a5a867
Compare
2a5a867
to
83a40a4
Compare
(cherry picked from commit 812cffe)
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
When you create a plugin that calls our internal executor for example
require.resolve('nx')
resolves to{workspaceRoot}/nx.json
This is because tsconfig-paths uses
require.extensions
which includes.json
Expected Behavior
require.resolve('nx')
should resolve to nx binary. For example located innode_modules/nx/bin/nx.js
Related Issue(s)
Filed an issue: dividab/tsconfig-paths#255
fixes: #19782