fix(Cronjob): don't restart CasparCG using the nightly cronjob if there's a Rundown active in the Studio (SOFIE-3618) #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re's a Rundown active in the Studio Skip until next day.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release52 #1365 +/- ##
=============================================
+ Coverage 56.48% 56.50% +0.01%
=============================================
Files 401 401
Lines 72257 72296 +39
Branches 4170 4595 +425
=============================================
+ Hits 40816 40852 +36
- Misses 31204 31309 +105
+ Partials 237 135 -102 ☔ View full report in Codecov by Sentry. |
nytamin
reviewed
Jan 27, 2025
meteor/server/cronjobs.ts
Outdated
Comment on lines
112
to
117
| RundownPlaylists.findFetchAsync( | ||
| { | ||
| activationId: { | ||
| $exists: true, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
This is perhaps nit-picking, as most/all Sofie installations we know of are single-studio at the moment, but since the data model allows for multi-studio:
This query will fail to match any indexes we've set up in MongoDB. Could we instead first query for the PeripheralDevices, and then use their studioId to filter in the query?
{
studioId: {$in: relevantStudioIds },
activationId: { $exists: true }
}
There was a problem hiding this comment.
Yeah, I guess I wanted to be fancy, but I'm good with doing this in series.
… fetch Playlists, to use the indexes in place
jstarpl
deleted the
fix/sofie-3618/casparcg-restarts-when-rundown-active
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Contributor
Type of Contribution
This is a:
Bug fix
Current Behavior
CasparCG servers will be restarted during "Low Season" (between 4:00 and 5:00) if the CasparCG restart cronjob is enabled
New Behavior
CasparCG cronjob will check if there's an active rundown in the Studio that owns the CasparCG to be restarted. If there is, the restart will be skipped until next day.
Testing
Affected areas
Time Frame
Other Information
Status