Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable localization + Properly passing values to JS #8

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

vyskoczilova
Copy link

@vyskoczilova vyskoczilova commented Apr 30, 2017

Hei! Tusen takk for deres fantastisk plugin! Firstly - if you would like to publish it in WP repo I'm open to help.

I have:

  • fixed untranslatable strings
  • added support for loading the plugin's textdomain (without you can't localize the plugin)
  • created a .pot file to make the localization easy
  • localized into Czech
  • disabled directly loading the PHP file (security)
  • enabled loading the script and style only on pages with open comments (loading optimization)
  • passed the arguments to the JS file by native WP localize script instead of loading it with data-attribute (optimization, security)

If you need more help, let me know.
Med vennlig hilsen fra Tsjekkia
Karolina

@vyskoczilova vyskoczilova changed the title Enable lozalization + Properly passing values to JS Enable localization + Properly passing values to JS Apr 30, 2017
@vyskoczilova
Copy link
Author

@henriklied @nrkbeta Your plugin is not dead ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant