Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more attributes of vacuum #14

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

KrzysztofHajdamowicz
Copy link
Contributor

This PR contains improvements created by @kovbalazs89, @pierosavi and @bashau in forks of this repository and merges them into one piece, allowing upstream repository to be in sync with downstream ones.
To be merged after #13

@raress96
Copy link

I have tested this after I also got the update of library from #15 and the changes from #13, and I can confirm that I have all the services in HA and at least from what I tested so far it seems to work ok on my model (viomi.vacuum.v8)

@X1pheR
Copy link

X1pheR commented Aug 27, 2020

Hi @nqkdev , could you please look at this PR of @KrzysztofHajdamowicz ? I would really love to use this custom component with all the added functionality. Would also be great to have it added to HACS too.

@nelsongraca
Copy link

For those interested I forked the repo and merged this and the pep8 PRs

@X1pheR
Copy link

X1pheR commented Nov 3, 2020

For those interested I forked the repo and merged this and the pep8 PRs

Great! In the meanwhile I'm using KrzysztofHajdamowicz/home-assistant-vacuum-styj02ym since it was the most up to date and gives me extra functionality and the bug resolved. How is yours compared to this one?

@KrzysztofHajdamowicz
Copy link
Contributor Author

For those interested I forked the repo and merged this and the pep8 PRs

Great! In the meanwhile I'm using KrzysztofHajdamowicz/home-assistant-vacuum-styj02ym since it was the most up to date and gives me extra functionality and the bug resolved. How is yours compared to this one?

KrzysztofHajdamowicz/home-assistant-vacuum-styj02ym@master...nelsongraca:master
They seem identical, where @nelsongraca has a little bit older dependencies.

@X1pheR
Copy link

X1pheR commented Nov 3, 2020

For those interested I forked the repo and merged this and the pep8 PRs

Great! In the meanwhile I'm using KrzysztofHajdamowicz/home-assistant-vacuum-styj02ym since it was the most up to date and gives me extra functionality and the bug resolved. How is yours compared to this one?

KrzysztofHajdamowicz/[email protected]:master
They seem identical, where @nelsongraca has a little bit older dependencies.

Thanks for the clarification. Didn't know you could compare that simple :)

@nelsongraca
Copy link

@KrzysztofHajdamowicz missed that you had an updated repo, in that case mine is useless, BTW is this the same as the viomi.vacuum.v8? I got that model and some attributes seem wrong.

@KrzysztofHajdamowicz
Copy link
Contributor Author

BTW is this the same as the viomi.vacuum.v8? I got that model and some attributes seem wrong.

Dunno :( I've just merged changes from existing forks of upstream repo, I own STYTJ02YM and it is hard for me to debug hardware I did not have in my hands :(

@nelsongraca
Copy link

Nevermind found the SKU: SKV4109GL not the same, time to try it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants