Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker support #92

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

nakedsushi
Copy link

@nakedsushi nakedsushi commented Aug 30, 2017

Adds a dockerfile to build a container that can just run the lunchbox app.

Also updates the readme w/ instructions on how to run the container. Long term, I want to clean up this README and make it more standardized.

@jottr
Copy link

jottr commented Aug 30, 2017

How do we know we can trust artursmet/python-2.7-node-6? There is no x Dockerfile source linked.

Why not simply use FROM python:2.7-alpine3.6 and add node via RUN apk add --update nodejs nodejs-npm?

This would make it more clear what the container is built on without unnecessary obfuscation and encapsulation.

@nakedsushi
Copy link
Author

Good point. Let me try rebuilding w/ alpine. I did that initially but ended up having to install a ton of other deps, which kind of defeated the point of alpine.

@nakedsushi
Copy link
Author

@jottr I created an automated build based on my branch for now. Dockerfile can be seen here:
https://hub.docker.com/r/scprdev/lunchbox/~/dockerfile/

@jjelosua
Copy link

jjelosua commented Sep 6, 2017

@nakedsushi on the README you are pointing to your own build...I am no expert on docker but wouldn't it make sense for the instructions to signal how to build and run the image locally using the repo dockerfile directly?

@nakedsushi
Copy link
Author

@jjelosua that's a good question. My intention in the README is to provide the easiest way to launch the app. Doing a docker pull of the image would mean the user wouldn't need to clone or download the repo or source code at all since the image is a standalone version.

What you're suggesting, building and running the image locally, would require the user to clone the repo, do a docker build to pretty much duplicate the image we already have here (https://hub.docker.com/r/scprdev/lunchbox/), and then a docker run of that image.

Or do you mean I should add in build instructions in case a user has updated assets for their own org's use and would like to build an image from that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants