-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker support #92
base: master
Are you sure you want to change the base?
Conversation
How do we know we can trust Why not simply use This would make it more clear what the container is built on without unnecessary obfuscation and encapsulation. |
Good point. Let me try rebuilding w/ alpine. I did that initially but ended up having to install a ton of other deps, which kind of defeated the point of alpine. |
* Uses 2.7.13-alpine3.6 https://hub.docker.com/_/python/
@jottr I created an automated build based on my branch for now. Dockerfile can be seen here: |
@nakedsushi on the README you are pointing to your own build...I am no expert on docker but wouldn't it make sense for the instructions to signal how to build and run the image locally using the repo dockerfile directly? |
@jjelosua that's a good question. My intention in the README is to provide the easiest way to launch the app. Doing a docker pull of the image would mean the user wouldn't need to clone or download the repo or source code at all since the image is a standalone version. What you're suggesting, building and running the image locally, would require the user to clone the repo, do a Or do you mean I should add in build instructions in case a user has updated assets for their own org's use and would like to build an image from that? |
Adds a dockerfile to build a container that can just run the lunchbox app.
Also updates the readme w/ instructions on how to run the container. Long term, I want to clean up this README and make it more standardized.