fix: Limit concurrent open files during lsstream
#285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
previously approved these changes
Jul 11, 2024
wraithgar
changed the title
lsstream
|
Sorry I didn't see that your other PR was in You'll need to fix linting before this can land. |
wraithgar
approved these changes
Jul 11, 2024
Merged
wraithgar
pushed a commit
that referenced
this pull request
Jul 11, 2024
🤖 I have created a release *beep* *boop* --- ## [18.0.4](v18.0.3...v18.0.4) (2024-07-11) ### Bug Fixes * [`5f2166a`](5f2166a) [#285](#285) Limit concurrent open files during `lsstream` (#285) (@oikumene) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During 'npm cache verify', currently all the cache files are open at the same time, which will bring EMFILE error in an environment that limit max open files.
This change limits the concurrent open files in garbageCollect() with p-map module to avoid this problem.
I first sent this pull request to npm/cli and it was merged, but realized that the original was in this repository.
References
npm/cli#7631
npm/cli#4783