-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api): Return correct workflow.origin #6740
Merged
Merged
+33
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SokratisVidros
temporarily deployed
to
Linting
October 22, 2024 10:23
— with
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
October 22, 2024 10:23
— with
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
October 22, 2024 10:23
— with
GitHub Actions
Inactive
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SokratisVidros
temporarily deployed
to
Linting
October 22, 2024 11:17
— with
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
October 22, 2024 11:17
— with
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
October 22, 2024 11:17
— with
GitHub Actions
Inactive
@novu/client
@novu/framework
@novu/headless
@novu/js
@novu/nextjs
@novu/node
@novu/notification-center
novu
@novu/providers
@novu/react-native
@novu/shared
@novu/react
commit: |
BiswaViraj
approved these changes
Oct 22, 2024
SokratisVidros
force-pushed
the
fix_workflow_origin
branch
from
October 22, 2024 17:13
bbc5d77
to
c4308bb
Compare
SokratisVidros
temporarily deployed
to
Linting
October 22, 2024 17:13
— with
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
October 22, 2024 17:13
— with
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
October 22, 2024 17:13
— with
GitHub Actions
Inactive
There are three origins: 1. V1 Workflows defined in Novu Cloud (will be deprecated soon) 2. V2 Workflows defined in Novu Cloud 3. V2 Workflows defined in code via @novu/framework The Dashboard will redirect to the appropriate workflow editor according to its origin.
SokratisVidros
force-pushed
the
fix_workflow_origin
branch
from
October 22, 2024 18:00
c4308bb
to
adbcf15
Compare
SokratisVidros
temporarily deployed
to
Linting
October 22, 2024 18:00
— with
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
October 22, 2024 18:00
— with
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
October 22, 2024 18:00
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
There are three origins:
The Dashboard will redirect to the appropriate workflow editor according to its origin.