-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate PDFs from Power Test Records #594
Generate PDFs from Power Test Records #594
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good thanks @jb3 , I think maybe there's a bit of discussion to be had about what else we think would be useful to show and refine the content as we probably also want stuff like event size on there but it's an excellent starting point
Thanks for the review. Will address lint failures shortly. |
CI issues now seem to be that the CI builder is trying to setup 3.9 whilst the Pipfile mandates 3.10, I can look at this in another PR but the linting issues are passing locally. |
Ugh the CI and tests have been broken for a while. If you have the time and energy to look at it that would be awesome 🤩 |
Feature
Allows for the export of PDFs, similar to how Risk Assessments can be exported, but for power test records from events.
This generates a two page document, the first page comprising of high level event detail such as:
The second page contains all the inputted values from the power test plan in a format similar to the HTML version.
Review status of the results is reflected on the first page, the table containing worst points scales depending on how many are inputted/stored.
Future Improvements
Speaking with Nick today in future it might be nice to expand power test records more with:
Miscellaneous
This PR also fixes the fact that exported PDFs never had a total number of pages, it would always say something like "Page 2 of 0", adding a
<namedString>
fixes this, we previously had a reference to this namedString but it didn't exist so the default of0
was used.