Support NAPALM 5.0.0 #72
Conversation
|
To check if the documentation still looks okay after updating sphinx from 4 to 7, I temporarily enabled the GitHub Pages on my fork: https://ubaumann.github.io/nornir_napalm/html/index.html |
pyproject.toml
Outdated
| nornir = { version = "~3", allow-prereleases = true } | ||
|
|
||
| [tool.poetry.dev-dependencies] | ||
| black = "^22.6.0" | ||
| mypy = "1.0.0" | ||
| black = "^24" |
There was a problem hiding this comment.
I pretty strongly think we should pin black, mypy, and pytest to exact versions as I don't want GH-actions to break just because of a poetry update.
All three of these tools are pretty annoying when you have to interrupt what you are doing to fix accidental breakage they caused (and these are all just dev dependencies i.e. doesn't affect general users and their installations).
There was a problem hiding this comment.
I totally understand. I pinned black, mypy, pytest, pytest-cov and nbval. At the moment, I am still enabling bugfixes with the ^24.3.0, or should I pin it hard to 24.3.0?
There was a problem hiding this comment.
I would hard pin black and mypy to an exact version (as I would much rather explicitly control any upgrade to both black and mypy).
pytest and pytest-cov bugfixes are probably fine (imo).
There was a problem hiding this comment.
I updated the PR with the exact pinning for black and mypy
|
Everything looks good to me except for the one comment I made with respect to some of the dev dependencies. We are pretty much guaranteeing future GH-actions problems if we don't pin them more tightly. |
|
Thanks @ubaumann |
|
FYI, I released nornir_napalm 0.5.0 to pypi: https://pypi.org/project/nornir-napalm/#history And made a tag for it in this repository. cc: @dbarrosop and @ubaumann |
Closes #70
I updated the dependencies to support now only NAPALM 5 versions.
I also did some house cleanings:
I bumped the version already to 0.5.0. The release still needs to be created, tagged and published.