Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core Container Component: Page #67

Merged
merged 1 commit into from
Dec 6, 2018
Merged

Core Container Component: Page #67

merged 1 commit into from
Dec 6, 2018

Conversation

arcticicestudio
Copy link
Contributor

Associated epic: #63
Relates to: #66
Resolves #65

@arcticicestudio
Implement core container component Page
f2d779c 
This is the base wrapper for page content of Nord Docs and renders the
HTML `main` element to wrap page content. It can be used in layout
components like the `BaseLayout` (1).

References:
  (1) #66

Associated epic: GH-63
Relates to: GH-66
GH-65
@arcticicestudio arcticicestudio added this to the 0.3.0 milestone Dec 6, 2018
@arcticicestudio arcticicestudio self-assigned this Dec 6, 2018
@codecov
Copy link

codecov bot commented Dec 6, 2018 •
edited
Loading

Codecov Report

Merging #67 into develop will increase coverage by 0.66%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #67      +/-   ##
===========================================
+ Coverage    79.66%   80.32%   +0.66%     
===========================================
  Files           20       21       +1     
  Lines           59       61       +2     
  Branches         9        9              
===========================================
+ Hits            47       49       +2     
  Misses           9        9              
  Partials         3        3
Flag Coverage Δ
#unit 80.32% <100%> (+0.66%) ⬆️
Impacted Files Coverage Δ
src/components/containers/core/Page/Page.jsx 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b78d69...f2d779c. Read the comment docs.

@arcticicestudio arcticicestudio merged commit 701ec43 into develop Dec 6, 2018
@arcticicestudio arcticicestudio deleted the feature/gh-65-core-container-component-page branch December 6, 2018 09:44
@arcticicestudio arcticicestudio removed their assignment Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svengreb svengreb svengreb approved these changes

Assignees
No one assigned
Labels
context-ui scope-ux type-feature
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@arcticicestudio @svengreb