Theme Mode Context #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arcticicestudio
commented
Dec 4, 2018
arcticicestudio
commented
To persist the current active theme mode when changing the route (which unmounts the `Root` component and therefore resets the state), the value will be written to the browser's session storage (1). The storage type has been preferred over the local storage (2) since this would persist the active theme mode even when the user closes the tab, but the desired behavior is to optimize the site for the "bright snow flurry" aura theme mode. To simplify the read- and write handling as well as prevent possible errors due to wrong storage keys, two utility functions have been implemented: - `readSessionCache(key : string)` - Reads the value of the given key from the session storage (if available). - `writeSessionCache(key : string, value : any)` - Writes the given key-value pair to the session storage (if available). References: (1) https://developer.mozilla.org/en-US/docs/Web/API/Window/sessionStorage (2) https://developer.mozilla.org/en-US/docs/Web/API/Window/localStorage Associated epic: GH-51 GH-57
The `Root` component has been changed from a SFC to a class component to store the currently active state and handle the theme mode toggle logic through a function. It also migrated the currently used simple "styled-component" theme (1) (provided through the `<ThemeProvider` component) to the styled-theming theme (2) that provides the initially implemented theme (GH-53). References: (1) https://www.styled-components.com/docs/advanced#theming (2) https://github.com/styled-components/styled-theming Associated epic: GH-51 GH-57
Codecov Report
@@ Coverage Diff @@
## develop #58 +/- ##
=========================================
- Coverage 91.66% 74% -17.67%
=========================================
Files 14 15 +1
Lines 24 50 +26
Branches 1 9 +8
=========================================
+ Hits 22 37 +15
- Misses 2 10 +8
- Partials 0 3 +3
Continue to review full report at Codecov.
|
svengreb
approved these changes
Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.