"Root" core container component (data provider) #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arcticicestudio
commented
Nov 20, 2018
arcticicestudio
commented
It renders the passed `children` within a `React.Fragment`. The `Root` core container is the first and one of the important main data provider React components of this project. It represents the base element and entry point that wraps the all custom application components and serves as a data provider later on. Some of the tasks in the future will be to - provide context props and functions for the global theme through styled-components (1) `ThemeProvider` (3) component - inject global styles through styled-components `createglobalstyle` (3) function including typography (GH-2) related data like application-wide used fonts - possibly data stores for state management libraries like MobX (4) References: (1) https://styled-components.com (2) https://www.styled-components.com/docs/api#createglobalstyle (3) https://www.styled-components.com/docs/api#themeprovider (4) https://mobx.js.org GH-36
This commit is the initial implementation and renders an self-closing "Root" component. GH-36
svengreb
approved these changes
Nov 20, 2018
arcticicestudio
deleted the
feature/gh-36-root-core-container-component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.