Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kubernetes 1.29.x in test matrix #24

Merged
merged 2 commits into from
Mar 17, 2024
Merged

Conversation

norbjd
Copy link
Owner

@norbjd norbjd commented Mar 17, 2024

Fixes #22.

Also fixes a flaky e2e test (when pod takes < 1 second to start, test will try to divide by zero: https://github.com/norbjd/k8s-pod-cpu-booster/actions/runs/8316283069/job/22755561778#step:8:44). So we will add 1 to avoid it. Adding a second won't really affect the result.

[INFO] pod-with-default-boost pod took 0 second(s) to be ready
[INFO] pod-no-boost pod took 7 second(s) to be ready
[INFO] pod from deployment-with-default-boost deployment took 0 second(s) to be ready
[INFO] pod from deployment-no-boost deployment took 7 second(s) to be ready
./test/e2e-kind.sh: line 46: 7 / 0 : division by 0 (error token is "0 ")
./test/e2e-kind.sh: line 48: 7 / 0 : division by 0 (error token is "0 ")

This is a temporary fix until #17 is solved.

@norbjd norbjd self-assigned this Mar 17, 2024
@norbjd norbjd merged commit a5a73ab into main Mar 17, 2024
3 checks passed
@norbjd norbjd deleted the kubernetes-1-29-e2e-tests branch March 17, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add kubernetes 1.29 in e2e test matrix
1 participant