Ce collect dependencies #183
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added findIndex to lib/extends.js
Open
DevSide
requested changes
Oct 4, 2016
| function findIndex(coll, item) { | ||
| var target = -1; | ||
| if( 'function' === typeof item ) { | ||
| coll.some(function(e, i) { |
| }); | ||
| } | ||
| else { | ||
| coll.some(function(e, i) { |
| @@ -227,6 +237,7 @@ var Rule = declare({ | |||
| this.name = name; | |||
| this.pattern = pattern; | |||
| this.cb = cb; | |||
| this.noLoop = options.noLoop; | |||
| } | ||
| return rules; | ||
| var rules = [], scope, patterns, isComposite; | ||
| function processConditions(conditions, scope) { |
There was a problem hiding this comment.
you can remove processConditions which is almost all createRule
| merged = [], | ||
| fnMerge = _mergePatterns(merged), | ||
| isRules = extd.every(conditions, function (cond) {return isArray(cond);}), | ||
| condition, rules, patterns; |
There was a problem hiding this comment.
then remove rules and patterns, they are declared upper
| }); | ||
| } | ||
| return rules; | ||
| var rules = [], scope, patterns, isComposite; |
| if(parts && parts.length ) { | ||
| rule.push('collect'); | ||
| rule.push(parts[2], parts[1]); | ||
| constraints = parts[3].trim(); |
There was a problem hiding this comment.
use replace(/^\s*|\s*$/g, "") like below, it's safer for tab char
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a merge of three other pull requests. I based the collect feature off of this branch.
#176 exposed ParseRules
#175 refactored createRule
#180 expose match class