Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ARN checks in the diagnostics report #1462

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added ARN checks in the diagnostics report #1462

wants to merge 3 commits into from

Conversation

achouhan09
Copy link
Member

@achouhan09 achouhan09 commented Oct 14, 2024 •
edited
Loading

Explain the changes

  1. Added ARN checks in the diagnostics report for both backingstores and namespacestores having AWS STS ARN string.
    Screenshot from 2024-10-30 19-00-55

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  1. Try running command noobaa diagnostics report to see the output.

@achouhan09 achouhan09 requested review from aspandey, liranmauda, shirady, a team and naveenpaul1 and removed request for a team October 14, 2024 11:34
@achouhan09 achouhan09 marked this pull request as draft October 14, 2024 11:34
@achouhan09 achouhan09 force-pushed the arn-check branch 2 times, most recently from 1fdfb2e to 7eaf663 Compare October 18, 2024 12:07
@achouhan09 achouhan09 marked this pull request as ready for review October 18, 2024 12:08
Neon-White
Neon-White requested changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@Neon-White Neon-White left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few rephrases and stylistic choices for you to consider, and one remark about the ARN check which I think might be incorrect

pkg/diagnostics/report.go Outdated Show resolved Hide resolved
pkg/diagnostics/report.go Outdated Show resolved Hide resolved
pkg/diagnostics/report.go Outdated Show resolved Hide resolved
pkg/diagnostics/report.go Outdated Show resolved Hide resolved
pkg/diagnostics/report.go Outdated Show resolved Hide resolved
pkg/diagnostics/report.go Outdated Show resolved Hide resolved
pkg/diagnostics/report.go Outdated Show resolved Hide resolved
pkg/diagnostics/report.go Outdated Show resolved Hide resolved
pkg/diagnostics/report.go Outdated Show resolved Hide resolved
Neon-White
Neon-White approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@Neon-White Neon-White left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

shirady
shirady reviewed Oct 27, 2024
View reviewed changes
pkg/diagnostics/report.go Outdated Show resolved Hide resolved
@shirady
Copy link
Contributor

shirady commented Oct 27, 2024

@achouhan09, Did you want to validate only AWS STS ARN?
If that is so, then the example in the PR description is confusing because it is not exactly the case.

@achouhan09
Copy link
Member Author

@achouhan09, Did you want to validate only AWS STS ARN? If that is so, then the example in the PR description is confusing because it is not exactly the case.

@liranmauda I am bit confused about AWS ARN check here. What are the requirements for this check?
Do we need to validate AWS STS ARN only for the stores here and print the status? Also, I think checking for bucket or object ARN doesn't make sense.

shirady
shirady approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@shirady shirady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neon-White Neon-White Neon-White approved these changes

@shirady shirady shirady approved these changes

@aspandey aspandey Awaiting requested review from aspandey

@liranmauda liranmauda Awaiting requested review from liranmauda

@naveenpaul1 naveenpaul1 Awaiting requested review from naveenpaul1 naveenpaul1 was automatically assigned from noobaa/dev

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@achouhan09 @shirady @Neon-White