Add support for configurable max bucket & key length #8484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangledbytes
force-pushed
the
utkarsh/feat/limit-key-length
branch
from
fa812e6
to
6754405
Compare
tangledbytes
changed the title
guymguym
requested changes
Oct 29, 2024
src/endpoint/sts/sts_rest.js
Outdated
| @@ -90,6 +90,8 @@ async function handle_request(req, res) { | |||
| } | |||
| req.op_name = op_name; | |||
|
|
|||
| http_utils.validate_bucket_name_object_key_length(req); | |||
There was a problem hiding this comment.
I don't think this is relevant to sts/iam requests at all - we don't parse a bucket/key params in those servers.
src/endpoint/iam/iam_rest.js
Outdated
| @@ -105,6 +105,8 @@ async function handle_request(req, res) { | |||
| } | |||
| req.op_name = op_name; | |||
|
|
|||
| http_utils.validate_bucket_name_object_key_length(req); | |||
There was a problem hiding this comment.
I don't think this is relevant to sts/iam requests at all - we don't parse a bucket/key params in those servers.
src/endpoint/s3/s3_rest.js
Outdated
| @@ -121,6 +121,8 @@ async function handle_request(req, res) { | |||
| } | |||
| req.op_name = op_name; | |||
|
|
|||
| http_utils.validate_bucket_name_object_key_length(req); | |||
There was a problem hiding this comment.
it seems more relevant in my opinion that this validation will be part of get_bucket_and_key()
src/util/http_utils.js
Outdated
| @@ -702,6 +702,15 @@ function validate_server_ip_whitelist(req) { | |||
| throw new S3Error(S3Error.AccessDenied); | |||
| } | |||
|
|
|||
| function validate_bucket_name_object_key_length(req) { | |||
There was a problem hiding this comment.
I don't think this fits http_utils, it can just be in s3_rest, or if we need to share it then maybe in s3_utils
Signed-off-by: Utkarsh Srivastava <[email protected]> add configurable for bucket name length Signed-off-by: Utkarsh Srivastava <[email protected]>
tangledbytes
force-pushed
the
utkarsh/feat/limit-key-length
branch
from
6754405
to
a80acc4
Compare
guymguym
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
This PR adds support for configurable max key length in NooBaa. Amazon S3 supports maximum of 1024 bytes long key name while NooBaa does not have any such limits. This sometimes become problematic hence this PR adds support for a config variable named
S3_MAX_KEY_LENGTHwhich defaults toInfinityfor now implying no limit, however this can be changed to 1024 inconfig-local.js.Issues: Fixed #xxx / Gap #xxx
Some known DBS3 issues.
Testing Instructions: