Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid dedup chunks that are relatively new #8482

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

dannyzaken
Copy link
Contributor

Explain the changes

  1. To prevent deduplicating chunks from a previous failed upload attempt, only consider deduping chunks that are older than a specific threshold.
  2. This is only a partial fix for the more general case. It only addresses the issue of failed upload retries. There is still a race condition between chunk deduplication and the object reclaimer flow.

Issues: Fixed #xxx / Gap #xxx

  1. https://bugzilla.redhat.com/show_bug.cgi?id=2256223

Testing Instructions:

  • Doc added/updated
  • Tests added

Copy link
Contributor

@liranmauda liranmauda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dannyzaken dannyzaken force-pushed the danny-dedup branch 4 times, most recently from 948e450 to a3f7eb8 Compare October 28, 2024 16:01
To prevent deduplicating chunks from a previous failed upload attempt, only consider deduping chunks that are older than a specific threshold.

related to https://bugzilla.redhat.com/show_bug.cgi?id=2256223

Signed-off-by: Danny Zaken <[email protected]>
@dannyzaken dannyzaken merged commit 348fe72 into noobaa:master Oct 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants