Skip to content

Commit

Permalink
Merge pull request #8456 from tangledbytes/utkarsh/fix/file-reader-pa…
Browse files Browse the repository at this point in the history
…rtial-encoded

[NSFS] Fix Newline Reader to work with partial reads and improve its memory usage
  • Loading branch information
tangledbytes authored Oct 31, 2024
2 parents aef68ca + c2bbbe5 commit b27e63b
Show file tree
Hide file tree
Showing 5 changed files with 183 additions and 30 deletions.
2 changes: 1 addition & 1 deletion src/sdk/nsfs_glacier_backend/tapecloud.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ class TapeCloudUtils {
throw new Error('process exited with non-zero exit code:', errcode);
}

reader = new NewlineReader(fs_context, tmp);
reader = new NewlineReader(fs_context, tmp, { skip_overflow_lines: true });
await reader.forEach(async line => {
const failure_case = line.startsWith("Fail");
const success_case = line.startsWith("Success");
Expand Down
Loading

0 comments on commit b27e63b

Please sign in to comment.