Skip to content

Commit

Permalink
fix new line reader to work when reads are partial and improve memory…
Browse files Browse the repository at this point in the history
… usage

Signed-off-by: Utkarsh Srivastava <[email protected]>

cleanup code

Signed-off-by: Utkarsh Srivastava <[email protected]>

fix reset method and rename config params

Signed-off-by: Utkarsh Srivastava <[email protected]>

handle overflow case

Signed-off-by: Utkarsh Srivastava <[email protected]>
Co-authored-by: Guy Margalit <[email protected]>
  • Loading branch information
tangledbytes and guymguym committed Oct 30, 2024
1 parent 9dece0e commit 1905da6
Show file tree
Hide file tree
Showing 5 changed files with 183 additions and 30 deletions.
2 changes: 1 addition & 1 deletion src/sdk/nsfs_glacier_backend/tapecloud.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ class TapeCloudUtils {
throw new Error('process exited with non-zero exit code:', errcode);
}

reader = new NewlineReader(fs_context, tmp);
reader = new NewlineReader(fs_context, tmp, { skip_overflow_lines: true });
await reader.forEach(async line => {
const failure_case = line.startsWith("Fail");
const success_case = line.startsWith("Success");
Expand Down
Loading

0 comments on commit 1905da6

Please sign in to comment.