[REFACTOR] 공통 메서드를 entity내 메서드로 수정 #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sung-silver
approved these changes
Jan 14, 2024
| @@ -38,4 +38,8 @@ public class UniversityExam { | |||
|
|
|||
| @NotNull | |||
| private int universityExamTimeLimit; | |||
|
|
|||
| public String getUniversityAndUniversityExamName(){ | |||
There was a problem hiding this comment.
함수이름 getUniversityFullName() 어떠신가요?? 시험년도도 들어가고있어서!! 아님 정보에서 사용되는 이름이라고해서 ExamInfoName..?
There was a problem hiding this comment.
ㅋㅋㅋㅋ 안그래도 좀 아쉬웠는데 예리하십니다 ㅋㅋㅋ
넘 좋습니다! 리뷰 반영해서 getUniversityExamFullName() 으로 하면 좋을 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 PR 타입
📝 반영 브랜치
📝 변경 사항
📝 테스트 결과
📝 To Reviewer