Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] 첨삭: 첨삭 PDF_해제PDF 시험정보 반환데이터 추가 #85

Merged
merged 2 commits into from
Jan 14, 2024
Merged

[FEAT] 첨삭: 첨삭 PDF_해제PDF 시험정보 반환데이터 추가 #85

merged 2 commits into from
Jan 14, 2024

Conversation

mikekks
Copy link
Contributor

@mikekks mikekks commented Jan 14, 2024

📝 PR 타입

  • 기능 추가
  • 기능 수정
  • 기능 삭제
  • 버그 수정
  • 의존성, 환경 변수, 빌드 관련 코드 업데이트

📝 반영 브랜치

📝 변경 사항

  • 첨삭 PDF_해제PDF 시험정보 반환데이터 추가

📝 테스트 결과

스크린샷 2024-01-14 오후 10 25 34

📝 To Reviewer

@mikekks mikekks requested a review from sung-silver January 14, 2024 13:25
@mikekks mikekks self-assigned this Jan 14, 2024
sung-silver
sung-silver approved these changes Jan 14, 2024
View reviewed changes
Copy link
Contributor

@sung-silver sung-silver left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!! UniversityExamRecord에서 UniversityExamService내 getUniversityExamName()함수를 public으로 바꾸고 원래있던 함수를 쓰는것도 좋을 것 같아요..! 뭐가 더 좋은 방향인지는 저도 좀 더 고민해보겠습니다

@mikekks
Copy link
Contributor Author

mikekks commented Jan 14, 2024

수고하셨습니다!! UniversityExamRecord에서 UniversityExamService내 getUniversityExamName()함수를 public으로 바꾸고 원래있던 함수를 쓰는것도 좋을 것 같아요..! 뭐가 더 좋은 방향인지는 저도 좀 더 고민해보겠습니다

저도 해당 부분 고민했어서 남겨주신 리뷰가 많이 공감이 되네요! 리팩 바로 해보겠습니다!

@mikekks mikekks merged commit 0badcfc into dev Jan 14, 2024
1 check passed
@mikekks mikekks deleted the feat/#84 branch January 14, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sung-silver sung-silver sung-silver approved these changes

Assignees

@mikekks mikekks

Labels
feat song
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] 첨삭: 첨삭 PDF_해제PDF 시험정보 반환데이터 추가
2 participants
@mikekks @sung-silver