[FEAT] S3 PreSignedUrl 발급 로직 구현 #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikekks
approved these changes
Jan 11, 2024
Comment on lines
-52
to
+62
|
|
||
| String redirectURL = "https://nid.naver.com/oauth2.0/authorize?client_id=" + clientId | ||
| + "&redirect_uri=" + redirectUri + "&response_type=code"; | ||
| try { | ||
| response.sendRedirect( | ||
| "https://nid.naver.com/oauth2.0/authorize?&client_id=iuUGaSHmzPMxKmNlc0BD&redirect_uri=http://localhost:8080/login/oauth2/code/naver&response_type=code"); | ||
| redirectURL); |
There was a problem hiding this comment.
오호 이렇게 바꾸니 좋네요! 보안 생각하면 이게 맞겠네요 굿굿!
| @@ -28,7 +28,7 @@ public class UniversityExamService { | |||
|
|
|||
| private final UniversityExamRepository universityExamRepository; | |||
| private final UniversityExamImageRepository universityExamImageRepository; | |||
| private final S3Service s3Service; | |||
| private final CloudFrontService cloudFrontService; | |||
Comment on lines
+6
to
+10
| public class FolderName { | ||
| public static final String EXAM_ANSWER_FOLDER_NAME = "exam-answer/"; | ||
| public static final String EXAM_RESULT_FOLDER_NAME = "exam-result/"; | ||
| public static final String EXAM_SHEET_FOLDER_NAME = "exam-sheet/"; | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 PR 타입
📝 반영 브랜치
📝 변경 사항
📝 테스트 결과
📝 To Reviewer