[FEAT] 첨삭 유무 검증 메서드 분리

nonsoolmate · Jan 16, 2024 · d395ba7 · d395ba7
1 parent dcbf82f
commit d395ba7
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/...te/nonsoolmateServer/domain/universityExamRecord/service/UniversityExamRecordService.java b/...te/nonsoolmateServer/domain/universityExamRecord/service/UniversityExamRecordService.java
@@ -40,9 +40,7 @@ public UniversityExamRecordResponseDTO getUniversityExamRecord(Long universityEx
         UniversityExam universityExam = getUniversityExam(universityExamId);
         UniversityExamRecord universityExamRecord = getUniversityExamByUniversityExamAndMember(universityExam, member);
 
-        if(universityExamRecord.getExamRecordResultFileName() == null){
-            throw new UniversityExamRecordException(INVALID_UNIVERSITY_EXAM_RECORD_RESULT_FILE_NAME);
-        }
+        validateCorrection(universityExamRecord);
 
         String answerUrl = cloudFrontService.createPreSignedGetUrl(EXAM_ANSWER_FOLDER_NAME,
                 universityExam.getUniversityExamAnswerFileName(), universityExam.getUniversityExamTimeLimit());
@@ -57,12 +55,20 @@ public UniversityExamRecordResultResponseDTO getUniversityExamRecordResult(Long
         UniversityExam universityExam = getUniversityExam(universityExamId);
         UniversityExamRecord universityExamRecord = getUniversityExamByUniversityExamAndMember(universityExam, member);
 
+        validateCorrection(universityExamRecord);
+
         String resultUrl = cloudFrontService.createPreSignedGetUrl(EXAM_RESULT_FOLDER_NAME,
                 universityExamRecord.getExamRecordResultFileName(), universityExam.getUniversityExamTimeLimit());
 
         return UniversityExamRecordResultResponseDTO.of(resultUrl);
     }
 
+    private void validateCorrection(UniversityExamRecord universityExamRecord) {
+        if(universityExamRecord.getExamRecordResultFileName() == null){
+            throw new UniversityExamRecordException(INVALID_UNIVERSITY_EXAM_RECORD_RESULT_FILE_NAME);
+        }
+    }
+
     @Transactional
     public UniversityExamRecordIdResponse createUniversityExamRecord(
             CreateUniversityExamRequestDTO request, Member member) {