Add a handler to detect resizes of the scrolling element #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... so that we can correctly update the scrollbars when the parent div changes size.
If we're creating a resize-monitor with native scrollbars, we still need to move the child elements into a viewElement, otherwise the resize monitor ends up monitoring the size of the scroll area, not the visible area.
This was referenced Apr 20, 2016
|
Thanks for the pull request (and sorry for the late response), @richvdh! let me take a look to make sure it's ready for merging, it seems pretty useful. 👍 |
|
Empirically, not on its own, unfortunately. Possibly the problem is that, as the zoom level changes, the relative size of the native scrollbar also changes - but we only check that relationship at first load. |
|
FWIW the It just causes the object to overlay everything as a white box. Seems to be ok with |
|
Thanks for the heads up @rhukster. |
|
@rhukster, fixed in v1.4.1 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In moderately complex applications, the size of the
HTMLElementcontaining our scrolling content can be affected by many other changes to the DOM. Every time ourHTMLElementis resized, we need to make sure that we callGeminiScrollbar.update. Trying to track each and every change to the DOM which results in a resize is difficult and fragile.This PR proposes the following solution: we overlay the
HTMLElementwith an invisible<object>with 100% width and height. To this object, we can attach an eventlistener which will be called whenever the parent element is resized; we can then use that to callGeminiScrollbar.update.This also makes the window resize event listener redundant.
We also provide a hook by which clients can be notified of resize events, with an
onResizemember in the constructor options.