fix autoshow functionality whilst dragging thumb of a scrollbar #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… view area whilst dragging thumb vertically
|
Thanks for the pull request @kakadiya91. I took a look to make sure it's ready for merging and found some changes are needed: .gm-scrollbar-container.gm-autoshow:hover .gm-scrollbar,
.gm-scrollbar-container.gm-autoshow:active .gm-scrollbar {
.gm-scrollbar-container.gm-autoshow:focus .gm-scrollbar {Should be: .gm-scrollbar-container.gm-autoshow:hover .gm-scrollbar,
.gm-scrollbar-container.gm-autoshow:active .gm-scrollbar,
.gm-scrollbar-container.gm-autoshow:focus .gm-scrollbar {Can you please update the pull request to address these? |
|
Thank you @kakadiya91, added in v1.4.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fix will make sure that in autoshow mode, it'll keep showing scrollbar if user moves cursor out of scrollview area horizontally whilst dragging thumb vertically.