Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How does this PR improve libqp?
Without this PR, when decoding a quoted-printable stream, some spaces will get silently dropped, depending on stream chunk boundaries. With this PR, spaces and tabs are preserved as specified in RFC2045.
Steps to reproduce the issue
Run the tests in this PR. Without this PR, 3 tests will fail:
Expected behavior
The decoded data should not change when the encoded data is provided in multiple stream chunks.
Actual behavior
Spaces and tabs are discarded, even though they should be preserved per RFC2045.
Related issues
We discovered the behavior when using nodemailer to parse quoted-printable encoded PDF attachments.
nodemailer #379: quoted-printable attachment missing some tabs might be related