Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update WPT for url to a23788b77a #56779

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of the WPT for url to web-platform-tests/wpt@a23788b.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 27, 2025
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jan 27, 2025
@anonrig
Copy link
Member

anonrig commented Jan 27, 2025

Review requested:

  • @nodejs/web-standards

I think this PR should request a review from @nodejs/url team.

@anonrig anonrig requested review from lemire and jasnell January 27, 2025 00:52
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 27, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 27, 2025
@nodejs-github-bot
Copy link
Collaborator Author

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.22%. Comparing base (1263efd) to head (e695fea).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #56779   +/-   ##
=======================================
  Coverage   89.22%   89.22%           
=======================================
  Files         663      663           
  Lines      191974   191974           
  Branches    36921    36923    +2     
=======================================
+ Hits       171282   171287    +5     
- Misses      13567    13568    +1     
+ Partials     7125     7119    -6     

see 19 files with indirect coverage changes

@legendecas
Copy link
Member

legendecas commented Jan 27, 2025

I think this PR should request a review from @nodejs/url team.

#56783 should add @nodejs/url as a codeowner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants