Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update winget manifest on new release #56774

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mdanish-kh
Copy link

Description

This PR proposes to add a GitHub action for submitting the latest stable release to WinGet as it gets published. microsoft/winget-create is used as the tool for generating and submitting the new manifests. The implementation assumes that the Installer URLs at https://nodejs.org/dist/ are available as soon as the release is published at GitHub.


Steps needed from maintainers

If the maintainers approve of these changes, they will need to do the following before merging this PR:

  1. Fork microsoft/winget-pkgs under a personal or bot account. Looking at discussion in PR build: automate winget package creation #34014, I assume this can be done under the bot account @nodejs-github-bot
  2. Create a personal access token (classic) with public_repo scope from the user account where the fork exists.
  3. Store the created token in a repository secret with the name WINGET_GITHUB_TOKEN

For reference, maintainers may see similar implemented actions in the following repos:
microsoft/terminal, microsoft/PowerToys, microsoft/DevHome, coder/coder


Validation

Validated the action works as expected in a test repo. See the run https://github.com/mdanish-kh/test-wingetcreate/actions/runs/12976977036/job/36189859568

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jan 26, 2025
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @nodejs/build @nodejs/releasers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants