Fix sqlite custom function callback errors reporting #56773
+34
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56772
Add error reporting for custom function callback errors to the sqlite API.
src/node_sqlite.cc
sqlite3_result_error()
inUserDefinedFunction::xFunc
when the JS callback throws an error.retval
check to handle the error condition and callsqlite3_result_error()
.test/parallel/test-sqlite-custom-functions.js
sqlite3_result_error()
being called.For more details, open the Copilot Workspace session.