-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix typo in cjs example of util.styleText
#56769
Conversation
Thanks @deokjinkim for creating this PR, but we just recently landed #56720. |
@UlisesGascon As I mentioned in PR description, only ESM example is fixed in #56720 like below: (line 1975) Lines 1969 to 1975 in ce6a628
CJS example is not fixed yet(line 1991). So I created this PR. Lines 1985 to 1991 in ce6a628
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right! Sorry for the early closing 😅
`errorMessage` needs to be printed instead of `successMessage` in console.error(). ESM example is only fixed in previous PR. Refs: nodejs#56720
385e706
to
243dfee
Compare
Landed in 7f18407 |
`errorMessage` needs to be printed instead of `successMessage` in console.error(). ESM example is only fixed in previous PR. Refs: #56720 PR-URL: #56769 Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jason Zhang <[email protected]> Reviewed-By: James M Snell <[email protected]>
errorMessage
needs to be printed instead ofsuccessMessage
in console.error().ESM example is only fixed in previous PR.
Refs: #56720