Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: be more generational GC friendly #56767

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

ywave620
Copy link
Contributor

@ywave620 ywave620 commented Jan 26, 2025

Avoid any potential ref to Buffer in new generation from old generation. Otherwise, the lightweight Minor GC could not collect Buffer, as a result, the heavy Major GC may be invoked more frequently

Similar tricks are used in Writable and Readable

buffered[i++] = null;

buf[idx++] = null;

Avoid any potential ref to Buffer in new generation
from old generation
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels Jan 26, 2025
Copy link

codecov bot commented Jan 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.21%. Comparing base (7119303) to head (e906371).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #56767      +/-   ##
==========================================
- Coverage   89.22%   89.21%   -0.01%     
==========================================
  Files         662      663       +1     
  Lines      192125   191976     -149     
  Branches    36972    36924      -48     
==========================================
- Hits       171421   171273     -148     
- Misses      13543    13566      +23     
+ Partials     7161     7137      -24     
Files with missing lines Coverage Δ
lib/_http_outgoing.js 95.24% <100.00%> (+<0.01%) ⬆️

... and 57 files with indirect coverage changes

@mcollina
Copy link
Member

tests are failing

@legendecas
Copy link
Member

Failed tests should be fixed by #56768. But the linter complaints shall be addressed.

@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 27, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 27, 2025
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants