src: add check for Bignum in GroupOrderSize #56702
Merged
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
jasnell
approved these changes
Jan 22, 2025
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #56702 +/- ##
==========================================
- Coverage 89.21% 89.21% -0.01%
==========================================
Files 662 662
Lines 191968 191969 +1
Branches 36955 36955
==========================================
- Hits 171269 171261 -8
- Misses 13535 13550 +15
+ Partials 7164 7158 -6
|
|
This needs a rebase to fix test failures. |
|
@wooffie please remove the merge commits, rebase and force push, thank you. |
I think it's missed, cause in this file we have example of checking result of BignumPointer::new Refs: nodejs#56692
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
|
Can you merge? Or something wrong? |
jasnell
approved these changes
Jan 29, 2025
|
@wooffie ... nothing wrong just required process. PRs with 2 or more approvals can land after 48 hours from opening, but if there's only one approval it must wait at least 7 days, which we just hit this morning. |
jasnell
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in f19ae14 |
targos
pushed a commit
that referenced
this pull request
Feb 2, 2025
I think it's missed, cause in this file we have example of checking result of BignumPointer::new Refs: #56692 PR-URL: #56702 Fixes: #56692 Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's missed, cause in this file we have example of checking result of BignumPointer::new
Fixes: #56692