Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the node-gyp alpine docs section to account for Node 18 in Alpine 3.20 python issue #2099

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

LaurentGoderre
Copy link
Member

@LaurentGoderre LaurentGoderre commented Jun 4, 2024

Technically, this is only needed for Node 18 on Alpine 3.20 but since it's part of the virtual group and gets deleted, this is the simplest without overcomplicating the docs.

  • Documentation
  • Version change (Update, remove or add more Node.js versions)
  • Variant change (Update, remove or add more variants, or versions of variants)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (none of the above)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • All new and existing tests passed.

@PeterDaveHello PeterDaveHello merged commit da735a9 into nodejs:main Jun 5, 2024
3 checks passed
@LaurentGoderre LaurentGoderre deleted the docs-18-alpine3.20 branch June 5, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants