Initial code to sign keyinfo #464
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
any plans to merge this? |
This was referenced Jan 30, 2025
|
@sibelius , yes, there are plans to merge this once it is done. Please feel free to contribute; I can use all the help I can get as recently I don't have much time for development on this project. |
sibelius
reviewed
Jan 31, 2025
| @@ -901,7 +937,14 @@ export class SignedXml { | |||
|
|
|||
| const keyInfoContent = this.getKeyInfoContent({ publicCert: this.publicCert, prefix }); | |||
| if (keyInfoAttrs || keyInfoContent) { | |||
| return `<${currentPrefix}KeyInfo${keyInfoAttrs}>${keyInfoContent}</${currentPrefix}KeyInfo>`; | |||
| const keyInfoXml = `<${currentPrefix}KeyInfo${keyInfoAttrs}>${keyInfoContent}<fake>2</fake></${currentPrefix}KeyInfo>`; | |||
|
should we remove whitespace before signing ? |
|
I'm checking the output from this reference implementation that works https://github.com/bacen/pix-dict-quickstart/blob/master/src/main/java/br/gov/bcb/pi/dict/xml/XMLSigner.java#L63 and the output of this package xml-crypto does not keep the \n inside ds:SignatureValue here is a print with the signature with \n should I implement or active this somehow ? I think this broke in your pull request, in main is working well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to provide a helper function to sign all children of the root node and a way to include keyinfo in the signature.
Closes: #463