Fix XFAIL behavior in conftest.py. #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renxida
pushed a commit
that referenced
this pull request
Jul 18, 2024
Fixes #86. The imperative `pytest.xfail()` does not actually XFAIL/XPASS, it acts as a "skip". This switches to using `self.add_marker(pytest.mark.xfail(...))` which actually works. Now that XFAIL/XPASS work, new XFAIL sets were generated with * llvm/torch-mlir@e48fe45 * iree-org/iree@e991798 This also highlights a need for a way to automatically update the XFAIL sets in the config files from a test run. I updated the config files here manually and it was quite a chore :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86. The imperative
pytest.xfail()does not actually XFAIL/XPASS, it acts as a "skip". This switches to usingself.add_marker(pytest.mark.xfail(...))which actually works.Now that XFAIL/XPASS work, new XFAIL sets were generated with
This also highlights a need for a way to automatically update the XFAIL sets in the config files from a test run. I updated the config files here manually and it was quite a chore :/