[alt] remove default iree-compile extra args from onnx-iree mode #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottTodd
reviewed
Sep 30, 2024
|
@ScottTodd Should I revert the change to the cl config to use |
That's probably safer for now. Since the new flag hasn't been fully adopted in the IREE repo and doesn't have much mileage on it, it may be buggy. That's going to be easier to reason about upstream first, and that sort of flag change can also be made independently from the rest of the cleanup here. |
zjgarvey
force-pushed
the
iree-config-updates
branch
from
dd4269e
to
ecab023
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always using
iree-input-demote-i64-to-i32was causing numerics problems since it wasn't loading i64 inputs correctly. Additionally the flags for specifying the chip forhipis out of date, and should be removed. Users should specify-ica "iree-hip-target=gfx942" "other-arg" "other-arg" ...if compiling for Mi300.