initial websocket bindings

[jacobrosenthal]

First pass at websocket bindings. Sorta works, but seems to spawn a new device every time.

Feedback obviously welcome.

I dont see any unit tests for bindings?

[jacobrosenthal]

Arbitrarily chose 0xB1f, one up from nobles websocket.

[jacobrosenthal]

I also missed this os check, https://github.com/sandeepmistry/bleno/blob/master/lib/bleno.js#L132

It seems innapropriate to os check a second time, and its (currently) impossible to know what bindings are under the WS hood...

Perhaps the bleno api should be identical no matter the platform, but rather send a null value for the unimplemented variables?

[jacobrosenthal]

Its not exactly unit tests, but I found the debug=bindings helpful in trying to determine if ws is properly passing through and executing the same bindings calls. All examples appear identical, heres the battery characteristic logs https://gist.github.com/jacobrosenthal/3aa67244397d2ffdb01a

[jacobrosenthal]

Interesting.. stop isnt working from the websocket bindings at the moment even thought the bindings logging look perfect. @sandeepmistry notice the super fast return time on the not working copy (15ms vs 155) Thoughts on that?
https://gist.github.com/jacobrosenthal/9728ad4ddb1d3c0bdc04

[sandeepmistry]

@jacobrosenthal looks ok on my Mac:

var eddystoneBeacon = require('./../../index');

eddystoneBeacon.advertiseUid('00010203040506070809', 'aabbccddeeff');

setTimeout(function() {
  console.log('stop');
  eddystoneBeacon.stop();
}, 5000);

Using LightBlue on iOS, could not discover my Mac. What are you using for the central?

[jacobrosenthal]

I havent been able to reproduce it anymore yet. Maybe just a weird blued state that day..

[jacobrosenthal]

Eddystone does a platform check as well which doesnt square with websocket:
don/node-eddystone-beacon#23

I have a platform check branch bringing os.platform call into bleno api so it can be used behind websocket that after some more testing and discussion Im going to merge here:
https://github.com/jacobrosenthal/bleno/tree/websocket-platformcheck

[sandeepmistry]

I have a platform check branch bringing os.platform call into bleno api so it can be used behind websocket that after some more testing and discussion Im going to merge here:
https://github.com/jacobrosenthal/bleno/tree/websocket-platformcheck

Like we've been discussing in don/node-eddystone-beacon#25 (comment) - I think we both agree the platform check can be a property instead of a async function

[jacobrosenthal]

Added a platform check

[rzr]

May I suggest to forward your changes to:

https://github.com/abandonware/bleno/

Meanwhile, feedback welcome on latest release:

https://www.npmjs.com/package/@abandonware/bleno/v/0.5.1-2

[rzr]

Please confirm this issue is resolved with @abandonware version

Relate-to: abandonware#17