Refactor listener; add flush #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reecepbcups
approved these changes
Mar 20, 2024
| stream, sub, history, err = etherReader.QueryWithHistory(ctx, &query) | ||
| if err != nil { | ||
| logger.Error("Unable to subscribe to logs", "attempt", queryAttempt, "err", err) | ||
| queryAttempt++ |
There was a problem hiding this comment.
if queryAttempt gets above a certain number should this ever panic? or just a descriptor for logging?
There was a problem hiding this comment.
My thinking here is that if for some reason the websocket is offline and it was unable to subscribe to logs, we should continue relaying and flushing other paths.
This would be a good place to add prometheus metrics so that an infra team can be notified about these errors.
This was referenced Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves several issues.
Introduce reoccurring flush
The
startcommand not accepts a--flush-intervalor-iflag and takes a duration.The relayer now tracks the "last-flushed-block".
When a flush interval is set:
The relayer will continuously look back
last-flushed-block - lookback period up to the latest blockand perform a flush.(
last-flushed-block - lookback periodmay be overkill? Potentially just flushlast-flushed-block up to latest block?)Handle disconnected ETH web sockets
Prior to this PR, if an ETH/L2 web socket was disconnected, the relayer would crash. We relied on the infrastructure the relayer was deployed in to restart it. We now handle disconnections gracefully picking up where it left off.
This will also:
Allow for larger ETH/L2 history queries
Depending on your ETH/L2 node or provider, you are only able to query a certain amount of history at once (we were running into this issue specifically with Avalanche). Now all ETH/L2 history queries are blocked in chunks of 100 blocks at a time.
Better handling of Clients and Cosmos Providers
This PR introduces
InitializeClients()andCloseClients()to the chain interface. This allows for better handling of clients/providers and allows for an organized cleanup in the event of a termination.