-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enforce usdc blacklist checks #5
Merged
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
45e890c
feat: enforce usdc blacklist checks
johnletey f2571ef
chore: merge main
johnletey 9f1f30e
Merge branch 'main' into usdc-blacklist
johnletey bb65ee8
fix: correct merge conflicts
johnletey 9e32436
test: added ftf test cases
g-luca 3c9b4cc
chore: minor cleanings
g-luca af66b12
chore: minor linter fixes
g-luca File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
package mocks | ||
|
||
import ( | ||
ftftypes "github.com/circlefin/noble-fiattokenfactory/x/fiattokenfactory/types" | ||
sdk "github.com/cosmos/cosmos-sdk/types" | ||
"github.com/noble-assets/halo/x/halo/types" | ||
) | ||
|
||
var _ types.FiatTokenFactoryKeeper = FTFKeeper{} | ||
|
||
type FTFKeeper struct { | ||
Paused bool | ||
} | ||
|
||
func (k FTFKeeper) GetBlacklisted(_ sdk.Context, bz []byte) (ftftypes.Blacklisted, bool) { | ||
return ftftypes.Blacklisted{AddressBz: bz}, false // TODO | ||
} | ||
|
||
func (k FTFKeeper) GetPaused(_ sdk.Context) ftftypes.Paused { | ||
return ftftypes.Paused{Paused: k.Paused} | ||
} | ||
|
||
func (k FTFKeeper) GetMintingDenom(_ sdk.Context) ftftypes.MintingDenom { | ||
return ftftypes.MintingDenom{Denom: "uusdc"} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implement the TODO in
GetBlacklisted
.The
GetBlacklisted
method currently returns a placeholder value. Ensure that the actual logic for retrieving blacklisted addresses is implemented.Would you like me to help implement the logic for this method or open a GitHub issue to track this task?