Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

design-proposal: dns probe name customize #1281

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

qinqon
Copy link
Member

@qinqon qinqon commented Jan 9, 2025

What this PR does / why we need it:
At some users customizing globally the dns probe name to resolve is a must, this change add a design doc to do it at NMState CR.

Related but for default gw:

Release note:

NONE

@kubevirt-bot kubevirt-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jan 9, 2025
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M labels Jan 9, 2025

Support customize kubernetes-nmstate DNS resolving probes at NMState CR.

## Motivation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also list the alternatives in this document. e.g. making the probe smarter, and having this configured on NNCP-level

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add an alternative about probe doing fallaback to a global name, about NNCP is stated as non goal and if needed can be done a new enhancement, we want this one to be very specific to reduce the number of knobs that we really need.

At some users customizing globally the dns probe name to resolve is a
must, this change add a design doc to do it at NMState CR.

Signed-off-by: Enrique Llorente <[email protected]>
@qinqon qinqon force-pushed the design-proposal-customize-dns-probe-name branch from e5d0d5e to b19a3ed Compare January 9, 2025 10:57
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from phoracek. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qinqon qinqon requested review from phoracek, cybertron and mkowalski and removed request for yboaron January 9, 2025 11:53
@kubevirt-bot
Copy link
Collaborator

@qinqon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-nmstate-unit-test b19a3ed link true /test pull-kubernetes-nmstate-unit-test
pull-kubernetes-nmstate-e2e-handler-k8s-future b19a3ed link false /test pull-kubernetes-nmstate-e2e-handler-k8s-future

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note-none Denotes a PR that doesn't merit a release note. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants