-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
design-proposal: dns probe name customize #1281
base: main
Are you sure you want to change the base?
design-proposal: dns probe name customize #1281
Conversation
|
||
Support customize kubernetes-nmstate DNS resolving probes at NMState CR. | ||
|
||
## Motivation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also list the alternatives in this document. e.g. making the probe smarter, and having this configured on NNCP-level
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will add an alternative about probe doing fallaback to a global name, about NNCP is stated as non goal and if needed can be done a new enhancement, we want this one to be very specific to reduce the number of knobs that we really need.
At some users customizing globally the dns probe name to resolve is a must, this change add a design doc to do it at NMState CR. Signed-off-by: Enrique Llorente <[email protected]>
e5d0d5e
to
b19a3ed
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@qinqon: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What this PR does / why we need it:
At some users customizing globally the dns probe name to resolve is a must, this change add a design doc to do it at NMState CR.
Related but for default gw:
Release note: