Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update model files to new ss exe #50

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Conversation

github-actions[bot]
Copy link
Contributor

Automated changes by create-pull-request GitHub action

Warning 11 : Fleet: 5 agecomp has obs with partition==2; will treat as partition=0 because retention not defined; N= 8
Warning 12 : Forecast F capped by max possible F from control file4
Warning 6 : At least one block pattern ends in endyr. Check the output parameter value time series to see if the values in forecast years are as intended.
Warning 7 Adjustment: Fleet: 1 agecomp has N obs with partition==2 (retained); changed to partition=0 because retention not defined; N= 105
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rick-Methot-NOAA Should we change the partitions in this model for the length compositions to just 0 so this error disappears in the warning.sso?

@Rick-Methot-NOAA
Copy link
Collaborator

suggest making suggested changes so that all these warnings go away.

@e-perl-NOAA
Copy link
Collaborator

See issue #51 for more details on changes made to some of the models to reduce the amount of warnings produced. Work to continue reducing the warnings will continue.

Copy link
Contributor

@iantaylor-NOAA iantaylor-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes look good. Warnings remain for some models, but this is a good start.

Note that changing the starter file in some models to remove the warning which starts with "Setting in starter does not request all priors..." causes the total likelihood to change due to the include of priors for non-estimated quantities. This is OK.

@e-perl-NOAA e-perl-NOAA merged commit 529836d into main Nov 2, 2023
@e-perl-NOAA e-perl-NOAA deleted the add-update-workflow-new branch November 2, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants