Skip to content

Commit

Permalink
REFACTOR: removed unneccessary web component packages (#1175)
Browse files Browse the repository at this point in the history
  • Loading branch information
JoeriRoijenga authored Jan 31, 2025
1 parent b71b116 commit 39c8aeb
Show file tree
Hide file tree
Showing 32 changed files with 16 additions and 1,300 deletions.
9 changes: 0 additions & 9 deletions .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,6 @@ coverage/
dist/
tmp/

# Ignore generated files from Stencil

components/components.d.ts
packages/web-components-angular/src/directives/angular-component-lib/utils.ts
packages/web-components-angular/src/directives/proxies.ts
packages/web-components-stencil/loader
packages/web-components-react/src/react-component-lib/
packages/web-components-react/src/components.ts

# Ignore Next.js project with own ESLint config

apps/rvs.rivm.nl/
Expand Down
14 changes: 0 additions & 14 deletions .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,20 +53,6 @@
"parser": "@typescript-eslint/parser",
"plugins": ["@typescript-eslint", "import", "eslint-plugin-import"]
},
{
"extends": [
"plugin:react/recommended",
"eslint-config-prettier",
"./.eslintrc.js.json",
"./.eslintrc.react.json"
],
"files": ["**/stencil.tsx", "**/*.stencil.tsx"],
"parser": "@typescript-eslint/parser",
"parserOptions": {
"project": ["packages/web-components-stencil/tsconfig.json"]
},
"plugins": ["@typescript-eslint", "import"]
},
{
"excludedFiles": ["**/stencil.tsx", "**/*.stencil.tsx"],
"extends": [
Expand Down
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ dist/
tmp/
**/src/generated/
**/src/generated/
packages/web-components-stencil/src/components.d.ts

# Ignore archives
*.7z
Expand Down
7 changes: 0 additions & 7 deletions .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,5 @@ package-lock.json
yarn.lock
pnpm-lock.yaml


# Ignore generated files from Stencil
components/components.d.ts
packages/web-components-stencil/loader
packages/web-components-react/src/react-component-lib/
packages/web-components-react/src/components.ts

# Ignore files that are edited from Figma
figma.tokens.json
14 changes: 6 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -171,14 +171,12 @@ Vanuit`packages/components-react` krijg je een gedetailleerder overzicht van tes

### Packages

| Package | Purpose |
| :----------------------- | :------------------------------------------------------------------------------------------------------------------------------------------------- |
| `components-css` | Hier kunnen CSS-componenten toegevoegd worden die nog niet bestaan in de NL Design System-community. |
| `components-react` | Optioneel voor het toevoegen van een React-wrapper aan een CSS-component als die nog niet bestaat. |
| `design-tokens` | Hier worden de rijkshuisstijl-thema’s beheerd, voor gebruik met NL Design System zonder thema. Opmerking deze zouden naar proprietary moeten gaan. |
| `storybook` | Extra componenten en pagina-sjablonen kunnen worden toegevoegd als story voor documentatie en visuele regressietesten. |
| `web-components-stencil` | Hier kunnen webcomponenten worden toegevoegd voor componenten die nog niet als webcomponent bestaan. |
| `web-components-react` | Hier kunnen React-webcomponenten toegevoegd worden voor gebruiksgemak. |
| Package | Purpose |
| :----------------- | :------------------------------------------------------------------------------------------------------------------------------------------------- |
| `components-css` | Hier kunnen CSS-componenten toegevoegd worden die nog niet bestaan in de NL Design System-community. |
| `components-react` | Optioneel voor het toevoegen van een React-wrapper aan een CSS-component als die nog niet bestaat. |
| `design-tokens` | Hier worden de rijkshuisstijl-thema’s beheerd, voor gebruik met NL Design System zonder thema. Opmerking deze zouden naar proprietary moeten gaan. |
| `storybook` | Extra componenten en pagina-sjablonen kunnen worden toegevoegd als story voor documentatie en visuele regressietesten. |

### Proprietary

Expand Down
3 changes: 0 additions & 3 deletions apps/rhc-templates/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,6 @@
"@rijkshuisstijl-community/font": "workspace:*",
"@rijkshuisstijl-community/rivm-design-tokens": "workspace:*",
"@rijkshuisstijl-community/storybook": "workspace:*",
"@rijkshuisstijl-community/web-components-react": "workspace:*",
"@rijkshuisstijl-community/web-components-stencil": "workspace:*",
"@tabler/icons-react": "3.28.1",
"@types/node": "20.17.6",
"@types/react": "19.0.7",
Expand All @@ -51,7 +49,6 @@
"@utrecht/page-body-react": "1.0.4",
"@utrecht/page-layout-react": "1.0.4",
"@utrecht/root-react": "1.0.4",
"@utrecht/web-component-library-react": "3.0.2",
"eslint": "9.18.0",
"eslint-config-next": "15.1.4",
"typescript": "5.7.3"
Expand Down
2 changes: 0 additions & 2 deletions apps/rvs.rivm.nl/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@
"@rijkshuisstijl-community/components-react": "workspace:*",
"@rijkshuisstijl-community/font": "workspace:*",
"@rijkshuisstijl-community/rivm-design-tokens": "workspace:*",
"@rijkshuisstijl-community/web-components-react": "workspace:*",
"@rijkshuisstijl-community/web-components-stencil": "workspace:*",
"@types/node": "20.17.6",
"@types/react": "19.0.7",
"@types/react-dom": "19.0.3",
Expand Down
1 change: 0 additions & 1 deletion packages/components-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
"dependencies": {
"@nl-design-system-candidate/heading-react": "1.0.0",
"@rijkshuisstijl-community/components-css": "workspace:*",
"@rijkshuisstijl-community/web-components-react": "workspace:*",
"@tabler/icons-react": "3.28.1",
"@utrecht/component-library-react": "7.3.5",
"clsx": "2.1.1",
Expand Down
6 changes: 0 additions & 6 deletions packages/storybook/config/preview.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,13 @@ import '@rijkshuisstijl-community/mijnoverheid-design-tokens/dist/theme.css';
import '@rijkshuisstijl-community/rivm-design-tokens/dist/theme.css';
import '@rijkshuisstijl-community/components-css/dist/index.css';
import { Paragraph } from '@rijkshuisstijl-community/components-react';
import { defineCustomElements } from '@rijkshuisstijl-community/web-components-stencil/loader/index';
import { withThemeByClassName } from '@storybook/addon-themes';
import { Controls, Description, Primary, Stories, useOf } from '@storybook/blocks';
import { Preview } from '@storybook/react';
import { PageLayout } from '@utrecht/page-layout-react';
import { Root } from '@utrecht/root-react';
import { defineCustomElements as defineUtrechtCustomElements } from '@utrecht/web-component-library-stencil/loader/index';
import { Fragment } from 'react';

// Initialize web components
defineCustomElements();
defineUtrechtCustomElements();

const preview: Preview = {
decorators: [
withThemeByClassName({
Expand Down
3 changes: 0 additions & 3 deletions packages/storybook/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,6 @@
"@rijkshuisstijl-community/mijnoverheid-design-tokens": "workspace:*",
"@rijkshuisstijl-community/rivm-design-tokens": "workspace:*",
"@rijkshuisstijl-community/web-components": "workspace:*",
"@rijkshuisstijl-community/web-components-react": "workspace:*",
"@rijkshuisstijl-community/web-components-stencil": "workspace:*",
"@storybook/addon-a11y": "8.4.7",
"@storybook/addon-actions": "8.4.7",
"@storybook/addon-docs": "8.4.7",
Expand All @@ -71,7 +69,6 @@
"@utrecht/page-layout-react": "1.0.4",
"@utrecht/root-react": "1.0.4",
"@utrecht/web-component-library-react": "3.0.2",
"@utrecht/web-component-library-stencil": "3.0.1",
"@whitespace/storybook-addon-html": "6.1.1",
"axe-playwright": "2.0.3",
"chromatic": "11.24.0",
Expand Down
2 changes: 0 additions & 2 deletions packages/web-components-react/.gitignore

This file was deleted.

25 changes: 0 additions & 25 deletions packages/web-components-react/README.md

This file was deleted.

49 changes: 0 additions & 49 deletions packages/web-components-react/package.json

This file was deleted.

1 change: 0 additions & 1 deletion packages/web-components-react/src/index.ts

This file was deleted.

19 changes: 0 additions & 19 deletions packages/web-components-react/tsconfig.json

This file was deleted.

4 changes: 0 additions & 4 deletions packages/web-components-stencil/.gitignore

This file was deleted.

25 changes: 0 additions & 25 deletions packages/web-components-stencil/README.md

This file was deleted.

59 changes: 0 additions & 59 deletions packages/web-components-stencil/package.json

This file was deleted.

25 changes: 0 additions & 25 deletions packages/web-components-stencil/src/icon-arrow-right/stencil.tsx

This file was deleted.

25 changes: 0 additions & 25 deletions packages/web-components-stencil/src/icon-calendar/stencil.tsx

This file was deleted.

Loading

0 comments on commit 39c8aeb

Please sign in to comment.